Add optional timeout to JSON-RPC daemon/wallet #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
timeoutargument toJSONRPCWalletandJSONRPCDaemonwhich is applied to all requests, fixing #18. The timeout defaults toNoneso this change is backwards compatible.The timeout is passed directly to
requests.postso it can be simply a number of seconds or a(connect timeout, read timeout)tuple (see https://3.python-requests.org/user/advanced/#timeouts).No special exceptions are raised. If needed, the caller will have to handle the
Timeoutexception fromrequests, similarly to what currently happens for other types of connection errors.