Invalid operation error

Author: p1c2u

openapi_core/exceptions.py

@@ -21,6 +21,10 @@ class InvalidContentTypeError(OpenAPIMappingError):
     pass
 
 
+class InvalidOperationError(OpenAPIMappingError):
+    pass
+
+
 class InvalidServerError(OpenAPIMappingError):
     pass
 

openapi_core/specs.py

@@ -6,6 +6,7 @@
 from openapi_spec_validator import openapi_v3_spec_validator
 
 from openapi_core.components import ComponentsFactory
+from openapi_core.exceptions import InvalidOperationError
 from openapi_core.infos import InfoFactory
 from openapi_core.paths import PathsGenerator
 from openapi_core.schemas import SchemaRegistry
@@ -35,7 +36,12 @@ def get_server_url(self, index=0):
         return self.servers[index].default_url
 
     def get_operation(self, path_pattern, http_method):
-        return self.paths[path_pattern].operations[http_method]
+        try:
+            return self.paths[path_pattern].operations[http_method]
+        except KeyError:
+            raise InvalidOperationError(
+                "Unknown operation path {0} with method {1}".format(
+                    path_pattern, http_method))
 
     def get_schema(self, name):
         return self.components.schemas[name]

openapi_core/wrappers.py

@@ -41,8 +41,9 @@ def get_operation(self, request, spec):
 
         operation_pattern = request.full_url_pattern.replace(
             server.default_url, '')
+        method = request.method.lower()
 
-        return spec.get_operation(operation_pattern, request.method.lower())
+        return spec.get_operation(operation_pattern, method)
 
     def _get_server(self, request, spec):
         for server in spec.servers:

tests/unit/test_specs.py

@@ -1,22 +1,50 @@
 import mock
 import pytest
 
+from openapi_core.exceptions import InvalidOperationError
+from openapi_core.paths import Path
 from openapi_core.specs import Spec
 
 
 class TestSpecs(object):
 
     @pytest.fixture
-    def spec(self):
+    def path1(self):
+        operations =  {
+            'get': mock.sentinel.path1_get,
+        }
+        return Path('path1', operations)
+
+    @pytest.fixture
+    def path2(self):
+        operations =  {
+            'post': mock.sentinel.path2_psot,
+        }
+        return Path('path2', operations)
+
+    @pytest.fixture
+    def spec(self, path1, path2):
         servers = []
         paths = {
-            'get': mock.sentinel.get,
-            'post': mock.sentinel.post,
+            '/path1': path1,
+            '/path2': path2,
         }
         return Spec(servers, paths)
 
-    @property
     def test_iteritems(self, spec):
         for path_name in spec.paths.keys():
             assert spec[path_name] ==\
                 spec.paths[path_name]
+
+    def test_valid(self, spec):
+        operation = spec.get_operation('/path1', 'get')
+
+        assert operation == mock.sentinel.path1_get
+
+    def test_invalid_path(self, spec):
+        with pytest.raises(InvalidOperationError):
+            spec.get_operation('/path3', 'get')
+
+    def test_invalid_method(self, spec):
+        with pytest.raises(InvalidOperationError):
+            spec.get_operation('/path1', 'post')