Add the default value for the 'servers' array #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The specification: https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.1.md#schemaObject clearly states that fields: - #/info - #/paths - #/components - #/components/schemas - #/components/responses - #/components/parameters - #/components/requestBodies are objects.
Get the list of allowed operations from openapi_spec_validator: https://github.com/p1c2u/openapi-spec-validator/blob/b2e439aa79c7cde932f9926f1ae124556924b10d/openapi_spec_validator/validators.py#L157
pbasista
force-pushed
the
bugfix/empty-servers
branch
2 times, most recently
from
60c04b3 to
cf58ac6
Compare
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
=========================================
+ Coverage 97.16% 97.3% +0.14%
=========================================
Files 18 18
Lines 883 892 +9
=========================================
+ Hits 858 868 +10
+ Misses 25 24 -1
Continue to review full report at Codecov.
|
pbasista
force-pushed
the
bugfix/empty-servers
branch
5 times, most recently
from
eaab23b to
253665e
Compare
The specification: https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.1.md#oasObject requires that if the 'servers' array is not provided or empty, its default value is an array of a single Server Object with 'url' of '/'.
pbasista
force-pushed
the
bugfix/empty-servers
branch
from
253665e to
a0305fb
Compare
Collaborator
|
@pbasista Nicely done. Thanks. |
bjmc
pushed a commit
to bjmc/openapi-core
that referenced
this pull request
Jun 12, 2019
Add the default value for the 'servers' array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specification:
https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.1.md#oasObject
requires that if the
serversarray is not provided or empty,its default value is an array of a single
Server Objectwith
urlof/.This can only be merged after PRs #13 and #14 are merged.