Fix mock import in Python 3.x #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`mock` is not installed on Python 3.x according to setup.cfg: `mock; python_version<"3.0"`. Import it from stdlib to fix the ImportError.
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
=======================================
Coverage 59.89% 59.89%
=======================================
Files 6 6
Lines 182 182
=======================================
Hits 109 109
Misses 73 73 Continue to review full report at Codecov.
|
p1c2u
reviewed
Mar 26, 2021
Collaborator
p1c2u
left a comment
p1c2u
left a comment
There was a problem hiding this comment.
LGTM I would just move it to combat module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mockis not installed on Python 3.x according to setup.cfg:mock; python_version<"3.0". Import it from stdlib to fix the ImportError.