Address jsonschema-rs backend review feedback#480
Merged
p1c2u merged 2 commits intopoc/rust-backendfrom Mar 1, 2026
Merged
Conversation
Merged
…, install docs, validate_formats Co-authored-by: p1c2u <1679024+p1c2u@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update jsonschema-rs backend for performance improvement
Address jsonschema-rs backend review feedback
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes several issues flagged in review of the jsonschema-rs backend PR.
Changes
validate_formats=Truefrom the Rust validator constructor — format validation is disabled by default in the Pythonjsonschemabackend (noformat_checkerpassed), so this prevented transparent backend switchingcls→validatorarg name inJsonschemaRsValidatorWrapper.__init__pip install jsonschema-rsinstall requirement note to bothREADME.rstanddocs/python.rst— the backend raisesImportErrorat runtime if the package is absent, so this must be documentedtests/bench/runner.pydocs/cli.rst🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.