Skip to content

(WIP) Table style options#462

Open
idahogray wants to merge 12 commits intopython-openxml:masterfrom
idahogray:table-style-options
Open

(WIP) Table style options#462
idahogray wants to merge 12 commits intopython-openxml:masterfrom
idahogray:table-style-options

Conversation

@idahogray
Copy link
Copy Markdown

@idahogray idahogray commented Jan 22, 2018

This merge request contains code that gives users the ability to enable/disable each of the Table Style Options:

  • Header Row
  • Total Row
  • Banded Rows
  • First Column
  • Last Column
  • Banded Columns

I am working on writing a feature file for this pull request. I will also provide updated documentation.

I would appreciate a review of the API if anyone can spare the time. I want to make sure it is consistent with the rest of the library.

This pull request will address #331.

  • Feature file
  • Documentation
  • Tests

References:

@MLubinski
Copy link
Copy Markdown

Setting the header row is much needed over here. Any plans to integrate some of these changes soon?

@jamesbcd
Copy link
Copy Markdown

This is a really useful patch. Any chance it could be brought up to date with the current master?

@jamesbcd
Copy link
Copy Markdown

hi @idahogray , this is a terrific patch. Is there any chance you could bring it up to date with the current master?

@idahogray
Copy link
Copy Markdown
Author

@jamesbcd I have merged with upstream/master.

@jamesbcd
Copy link
Copy Markdown

@idahogray thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants