Add deepcopy / pickle compatibility #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolkedebruin
force-pushed
the
add_deepcopy
branch
4 times, most recently
from
8e7c033 to
070a02f
Compare
4 tasks
bolkedebruin
force-pushed
the
add_deepcopy
branch
2 times, most recently
from
24bfa11 to
2da9108
Compare
Contributor
Author
|
@sdispater Can you please take a look? We (Airflow) could definitely use a release with this patch added. |
Python's doc say: "A tzinfo subclass must have an __init__() method that can be called with no arguments". Timezone and TimezoneInfo don't honor this requirement. Defining __getinitargs__ is sufficient to fix copy/deepcopy as well as pickling/unpickling. This introduces __tzinfos to Timezone as otherwise recursion errors will happen due to TimezoneInfo having a reference to Timezone.
bolkedebruin
force-pushed
the
add_deepcopy
branch
from
2da9108 to
e7d5392
Compare
Collaborator
|
@bolkedebruin Looks good to me 👍 I will merge this and make a new bugfix release later today. |
Contributor
Author
|
That’s much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python's doc say: "A tzinfo subclass must have an init() method that can
be called with no arguments". TimezoneInfo doesn't honor this
requirement. Defining getinitargs is sufficient to fix copy/deepcopy as
well as pickling/unpickling.
This is #134 implemented