Fix unpickling with undefined / empty timezone name #174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to fix #167.
Basically, the issue was that Pendulum defaults to
""for the local timezone name if it can't be determined properly, but thetzattribute ofPendulum()does not accept empty string. This was causing an error while trying to re-create a pickled instance ofPendulum.To fix that, I made use of #161. Now that
TimezoneInfoobjects are picklable, we can directly use them to serialize any instance of Pendulum, rather than their string representation.I also had to fix a small bug in the
__getinitargs__()method of theFixedTimezoneclass, as it should return a tuple but it did not.Any
Penduluminstance with an empty timezone name should now be correctly unpickable.As to why the timezone name could not be determined, it seems to be a bug with Windows 10 bash shell. Here is a discussion of another project facing the same issue: HowardHinnant/date#102
There does not seem to be any way to know the timezone's name. However, it is recommended to run
sudo dpkg-reconfigure tzdatato fix it, which I did and it works fine now.