is_utc() returns False when parsing from a UTC date #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redlickigrzegorz
force-pushed
the
bugfix/293-is_utc_returns_false_when_parsing_from_a_utc_date
branch
from
06413e0 to
3b85cee
Compare
joaonc
approved these changes
Nov 10, 2018
joaonc
left a comment
joaonc
left a comment
There was a problem hiding this comment.
Changes look good. Hope this gets merged soon.
Contributor
Author
|
@sdispater What do you think about my solution? Is it a good idea to think about the merge to resolve the problem? |
Collaborator
|
Thanks for your contribution! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a pull request for resolving the problem of
is_utc()method -> #293I created additional two assertions and prepare the code which resolves the problem without the breaking anything else, I hope.
Furthermore, I think that this method should return
Truefor"GMT"timezone because there is no time difference between Greenwich Mean Time and Coordinated Universal Time.