Skip to content

is_utc() returns False when parsing from a UTC date #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2020
Merged

is_utc() returns False when parsing from a UTC date #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pendulum/datetime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ def is_local(self):
return self.offset == self.in_timezone(pendulum.local_timezone()).offset

def is_utc(self):
return self.timezone_name == "UTC"
return self.offset == UTC.offset

def is_dst(self):
return self.dst() != datetime.timedelta()
Expand Down
5 changes: 4 additions & 1 deletion tests/datetime/test_getters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,10 @@ def test_utc():
assert not pendulum.datetime(2012, 1, 1, tz="America/Toronto").is_utc()
assert not pendulum.datetime(2012, 1, 1, tz="Europe/Paris").is_utc()
assert pendulum.datetime(2012, 1, 1, tz="UTC").is_utc()
assert not pendulum.datetime(2012, 1, 1, tz="GMT").is_utc()
assert pendulum.datetime(2012, 1, 1, tz=0).is_utc()
assert not pendulum.datetime(2012, 1, 1, tz=5).is_utc()
# There is no time difference between Greenwich Mean Time and Coordinated Universal Time
assert pendulum.datetime(2012, 1, 1, tz="GMT").is_utc()


def test_is_dst():
Expand Down