fix(locale): use Japanese date formats for the ja locale#977
Merged
Conversation
Secrus
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
jalocale'sdate_formatswere left with the English/US defaults, so localized format tokens render Japanese dates in English order with US separators:Every other CJK locale already localizes these.
zhusesYYYY年MMMD日/Ah点mm分andkousesYYYY년 MMMM D일/A h시 m분, sojais the one left on the defaults. The values here match the standard Japanese formats used by Moment.js and Day.js (locale/ja):After the change:
Only the format strings change; the day and month names still come from the existing
jaCLDR data. I added ajablock totest_date_formatsnext to the existingfrassertions. It fails on the old formats and passes on the new ones, andzh/kooutput is unchanged.