Add new2 function to pildriver.py #2502
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like a good idea. I'd like a better name than new2, perhaps new_mode or something that gives a clue about what the difference is between new and new2. It appears that we have no tests on pildriver (or likely, any of the scripts). It would be a good thing to add some tests to document that it's doing what we expect. |
Currently `new` function creates a grayscale image in stack, it will break `paste` a colorful(i.e. `RGBA`) image. Repro Steps ``` pildriver.py save new.png paste open test1.png 0 200 paste open test2.png 0 0 new 400 400 0 ``` We will get a **grayscale** new.png rather than a **RGBA** one. This commit is to fix this by adding a new `new_mode` function. ``` pildriver.py save new.png paste open test1.png 0 200 paste open test2.png 0 0 new2 RGBA 400 400 0 ```
|
Closing this as these scripts now live in their own repo at https://github.com/python-pillow/pillow-scripts. PRs welcome over there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
newfunction creates a grayscale image in stack, it will breakpastea colorful(i.e.RGBA) image.Repro Steps
We will get a grayscale new.png rather than a RGBA one.
This commit is to fix this by adding a new
new2function.