perf: allow to create Link with given filename

[radoering]

Extracting the filename from the URL is quite expensive and PEP 691 mandates a filename field anyway.

This can be used downstream to speed up locking by about 15 % in some cases.

• Added tests for changed code.
• Updated documentation for changed code.

[sourcery-ai]

Hey - I've left some high level feedback:

• In Link.__init__, consider checking if filename is not None instead of if filename: so that falsy but valid filenames (e.g. empty strings) are not silently ignored.
• Overwriting the filename cached_property by assigning self.filename = filename in __init__ is a bit subtle; it may be clearer to store the provided filename in a private attribute (e.g. self._filename) and have the filename property/cached_property read from that, to avoid instance-level shadowing of the descriptor.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In `Link.__init__`, consider checking `if filename is not None` instead of `if filename:` so that falsy but valid filenames (e.g. empty strings) are not silently ignored.
- Overwriting the `filename` cached_property by assigning `self.filename = filename` in `__init__` is a bit subtle; it may be clearer to store the provided filename in a private attribute (e.g. `self._filename`) and have the `filename` property/cached_property read from that, to avoid instance-level shadowing of the descriptor.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}