[PoC] extract build logic from the Command class#10075
Closed
Secrus wants to merge 1 commit intopython-poetry:mainfrom
Closed
[PoC] extract build logic from the Command class#10075Secrus wants to merge 1 commit intopython-poetry:mainfrom
Secrus wants to merge 1 commit intopython-poetry:mainfrom
Conversation
Reviewer's Guide by SourceryThis pull request extracts the build logic from the Sequence diagram showing the new build process flowsequenceDiagram
participant PC as PublishCommand
participant BC as BuildCommand
participant Env as EnvManager
participant Poetry
PC->>Env: create_venv()
Env-->>PC: env
PC->>BC: build(poetry, env, io, output)
BC->>Poetry: check is_package_mode
BC->>BC: setup build environment
BC->>BC: process build formats
BC->>BC: build package
BC-->>PC: return status
Class diagram showing the refactored BuildCommand classclassDiagram
class BuildCommand {
+handle() int
+static build(poetry: Poetry, env: Env, io: IO, format: str, clean: bool, local_version_label: str, output: str) int
}
note for BuildCommand "Build logic extracted to static method"
class PublishCommand {
+handle() int
}
PublishCommand ..> BuildCommand : uses build()
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PoC of "actions" API, starting with the
buildcommand.Summary by Sourcery
New Features:
buildfunction to handle the build process.