Skip to content

fix #686 encode credentials in install case#1402

Closed
oleastre wants to merge 1 commit into
python-poetry:masterfrom
oleastre:url-encode-credentials
Closed

fix #686 encode credentials in install case#1402
oleastre wants to merge 1 commit into
python-poetry:masterfrom
oleastre:url-encode-credentials

Conversation

@oleastre
Copy link
Copy Markdown

Quick fix for #686
This PR just fixes the install code path as the other one seems to forward the credentials to other components that should properly generate their own url.

@kasteph kasteph added the kind/bug Something isn't working as expected label Sep 24, 2019
@kasteph
Copy link
Copy Markdown
Member

kasteph commented Sep 24, 2019

@oleastre Thanks for your PR!

This is a duplicate of #1341 (which has a test) so I will close this PR.

@kasteph kasteph closed this Sep 24, 2019
@oleastre
Copy link
Copy Markdown
Author

#1341 fixes the develop branch while this one fixes the master branch.
The code that generates the index url is contained in the installer object and not in the repository like in the new develop version.
And there is no existing test for the pip_installer.install method on master. So I did not created one from scratch.
But if absolutely required to solve that bug, I can write one.

@chrispblink
Copy link
Copy Markdown

Just in case someone ends up here trying to make poetry 0.12.* work with 19.* and private repos and special chars in your creds: check out this little wrapper utility called pooetry

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

kind/bug Something isn't working as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants