Skip to content

ci: yet more enhancements / chore: more fixed lints#4773

Merged
neersighted merged 11 commits intomasterfrom
neersighted/more-lint-ci
Nov 16, 2021
Merged

ci: yet more enhancements / chore: more fixed lints#4773
neersighted merged 11 commits intomasterfrom
neersighted/more-lint-ci

Conversation

@neersighted
Copy link
Copy Markdown
Member

@neersighted neersighted commented Nov 16, 2021

Also contains minor reformats/refactors.

  • Improve flake8 config (almost fully commented/de-culted)
  • Add flake8-comprehensions and fix lints.
  • Add flake8-typing-imports and fix lints.
  • Strip meaningless noqa using yesqa.
  • Remove blanket noqas and replace type comments with annotations
  • Have Github Actions annotate test failures.
  • Drop the no-op Code Quality workflow.
  • Add some additional flake8 lints (no implicit namespaces, no backslashes, no untidy imports (e.g. no import foo.bar as bar).

I've touched install-poetry.py -- once I've got the lints in this repo to satisfaction I plan to PR them to install.python-poetry.org with the install-poetry.py changes.

@neersighted neersighted force-pushed the neersighted/more-lint-ci branch from 7a767de to a5858de Compare November 16, 2021 10:45
@neersighted neersighted changed the title ci: yet more enhancements ci: yet more enhancements / chore: more fixed lints Nov 16, 2021
@neersighted neersighted force-pushed the neersighted/more-lint-ci branch from a5858de to 4860978 Compare November 16, 2021 10:51
Comment thread .flake8 Outdated
Comment thread tests/installation/test_installer.py Outdated
Comment thread tests/installation/test_installer_old.py Outdated
@neersighted neersighted force-pushed the neersighted/more-lint-ci branch from 7b54824 to a211583 Compare November 16, 2021 14:50
Comment thread .flake8
Comment thread .flake8 Outdated
@neersighted neersighted force-pushed the neersighted/more-lint-ci branch from 7f3f318 to 413ac5d Compare November 16, 2021 16:35
@neersighted neersighted force-pushed the neersighted/more-lint-ci branch from 413ac5d to d3d5582 Compare November 16, 2021 16:37
neersighted added a commit to python-poetry/install.python-poetry.org that referenced this pull request Nov 16, 2021
This resolves some code smells found during python-poetry/poetry#4773. I
have not yet added the new lints to this repo, but I once they're
relatively stable/agreed on the main repo I will PR them here.
Copy link
Copy Markdown
Contributor

@danieleades danieleades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neersighted neersighted merged commit 25cc6a1 into master Nov 16, 2021
@neersighted neersighted deleted the neersighted/more-lint-ci branch November 16, 2021 16:45
neersighted added a commit to python-poetry/install.python-poetry.org that referenced this pull request Nov 16, 2021
This resolves some code smells found during python-poetry/poetry#4773. I
have not yet added the new lints to this repo, but I once they're
relatively stable/agreed on the main repo I will PR them here.
@github-actions
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants