Trim comments when setting InlineTable #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InlineTable is supposed to be one liner and doesn't support comments in values.
Codecov Report
@@ Coverage Diff @@
## master #31 +/- ##
==========================================
+ Coverage 91.67% 91.82% +0.15%
==========================================
Files 10 10
Lines 2017 2019 +2
==========================================
+ Hits 1849 1854 +5
+ Misses 168 165 -3
Continue to review full report at Codecov.
|
Member
|
Thanks! Looks good to me 👍 |
|
Thanks for the quick responses and for putting together a good toml library for python, it was badly needed |
capuanob
pushed a commit
to capuanob/tomlkit
that referenced
this pull request
Mar 1, 2023
* Trim comments when setting InlineTable InlineTable is supposed to be one liner and doesn't support comments in values. * Add tests * Fix coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InlineTable is supposed to be one liner and doesn't support comments in values.
Closes #30