Skip to content

Conversation

@jcborras
Copy link

Prevents the behaviour in #72 from arising.

Prevents the behaviour in [python-postgres#72|python-postgres#72] from arising.
@jwp
Copy link
Contributor

jwp commented Aug 22, 2014

I'm disinclined to accept this on grounds that Amazon is out of line. Additional Startup parameters are properly handled by every other server that I know of (pgpool and pgbouncer).

@jwp jwp closed this Aug 22, 2014
@jcborras
Copy link
Author

I respect that. Notice however that setting the param to None does not void its setting.

@jwp
Copy link
Contributor

jwp commented Aug 22, 2014

Yeah, I should probably send out an e-mail to the list. I think patching is semi-reasonable.

@chriscannon
Copy link

Why was this not merged? It was such a simple solution to the problem.

@jwp
Copy link
Contributor

jwp commented Mar 4, 2015

Got this confused with a different patch. I already commented on why I didn't merge it.

@chriscannon
Copy link

I read your rationale, but it doesn't make sense. As a user of the library, I should be able to unset any options that are passed to the Postgres database. It's a two-line change that makes the library more robust. It has nothing to do with Amazon.

@jwp
Copy link
Contributor

jwp commented Mar 15, 2015

The patch as is doesn't accommodate for empty strings which will trigger the condition. He needs to use an is None check. There are no included unit tests exercising the new functionality. My perception is that it is beyond unreasonable for Amazon to disallow the passing of the client_min_messages as part of the Startup message. It almost feels like they wrote it broken on purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants