Run coveralls using travis for PRs #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
It doesn't seem as if this has worked - all the tests are failing because of Coveralls running. |
SVilgelm
force-pushed
the
skip-coveralls-for-forks
branch
4 times, most recently
from
edf0c47 to
09889c6
Compare
SVilgelm
changed the title
Contributor
|
Working now. +1 |
j5awry
approved these changes
Feb 9, 2020
Contributor
Author
|
Let's merge it to unblock the CI? @SteadBytes @ziirish any thoughts? |
SVilgelm
changed the title
Contributor
Author
|
@SteadBytes @ziirish @j5awry I added travis to run the coveralls for PRs |
Contributor
|
Running two separate CI builds seems overkill 😅 - but if it's a quick and temporary solution to this problem then I'm happy with it. Let's make sure this gets re-addressed soon 👍 Before merging can you please add a full explanation of this change in the commit message? 👍 |
Contributor
Author
|
sure |
added 2 commits
February 11, 2020 08:43
Due to inability to use the COVERALLS_TOKEN secret for the PRs made from forks
It's a temporary solution and will be replaced by Codecov when the tokenless upload is implemented:
codecov/codecov-action#29
Temporary using Travis CI to run coveralls for PRs
SVilgelm
force-pushed
the
skip-coveralls-for-forks
branch
from
6c930c1 to
771f69a
Compare
ziirish
approved these changes
Feb 11, 2020
Contributor
|
Or not... @ziirish |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skipping the Coveralls step if action is run in a fork repo in the GitHub Actions
Using Travis to run the coveralls for PRs
Example: https://github.com/SVilgelm/flask-restx/runs/433679573?check_suite_focus=true
It's temporary solution until the codecov/codecov-action#29 is resolved