Skip to content

Conversation

@ccoors
Copy link
Contributor

@ccoors ccoors commented Jul 17, 2024

This is the current state of my example SCIM provider WSGI application.

Moved implementation to scim2-server. Added as submodule here.

@azmeuk
Copy link
Contributor

azmeuk commented Jul 23, 2024

Hi @ccoors
Thank you for your contribution! I will try to gather enough time to review your PR in the coming days/weeks.

@ccoors ccoors force-pushed the feature/example-scim-provider branch 2 times, most recently from 086409d to 2932e5c Compare August 2, 2024 19:48
@ccoors
Copy link
Contributor Author

ccoors commented Aug 2, 2024

I have managed to implement PATCH :) Now working on Sorting and will probably also do Bulk.

@azmeuk
Copy link
Contributor

azmeuk commented Aug 5, 2024

Hi. I still could not find much time for reviewing your work, but I don't lose hope!

@ccoors ccoors force-pushed the feature/example-scim-provider branch from 2932e5c to 003641c Compare August 6, 2024 17:27
@ccoors
Copy link
Contributor Author

ccoors commented Aug 6, 2024

Hi. I still could not find much time for reviewing your work, but I don't lose hope!

No worries! Just today we reached an "acceptable" state. Apart from Bulk (which we won't implement for the time being) everything works well enough for our use-case. We also tested this exact example provider against Microsoft Entra and could verify that it works.

Our main motivation for merging this example into this repo is to ensure it "stays green" with any changes to scim2-models. As I said, if you're not happy with the example that's totally fine too, we can move it to our own repo.

@ccoors ccoors force-pushed the feature/example-scim-provider branch from 003641c to 718c8f0 Compare August 7, 2024 08:44
@ccoors ccoors marked this pull request as ready for review August 7, 2024 09:55
@ccoors ccoors force-pushed the feature/example-scim-provider branch from 718c8f0 to c54eacd Compare August 7, 2024 12:13
@azmeuk
Copy link
Contributor

azmeuk commented Aug 18, 2024

I was thinking that maybe we could add your example server implementation in another repo.
To keep the codebase synchronized with scim2-models, we could then add it as a subrepository here.
If it is good for you, I will create a scim2-example-server repository and give you commit permissions. What do you think?

@ccoors
Copy link
Contributor Author

ccoors commented Aug 19, 2024

Yes, that sounds fine. Git submodules are a bit annoying to work with, but in this instance I guess it's okay.

@azmeuk
Copy link
Contributor

azmeuk commented Aug 19, 2024

Ok. I invited you on https://github.com/yaal-coop/scim2-server

@ccoors ccoors force-pushed the feature/example-scim-provider branch 2 times, most recently from 829da35 to 64a0997 Compare August 19, 2024 13:21
@ccoors ccoors force-pushed the feature/example-scim-provider branch from 64a0997 to 0dfb6af Compare August 19, 2024 13:25
@ccoors
Copy link
Contributor Author

ccoors commented Aug 19, 2024

@azmeuk I added the server in scim2-server and modified this PR, so that it uses it as a submodule. I'm not sure this will provide an 'easy' workflow for future changes in scim2-models, as you may have to synchronize changes across two repos. Maybe try it out for now?

@azmeuk
Copy link
Contributor

azmeuk commented Aug 29, 2024

Closing in favor of #71

@azmeuk azmeuk closed this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants