feat: implement session restore when cookies are not reliable #1159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nijel
added a commit
to nijel/social-app-django
that referenced
this pull request
May 21, 2025
This is a Django implementation for changes introduced in python-social-auth/social-core#1159. Fixes python-social-auth#481
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1159 +/- ##
==========================================
- Coverage 77.87% 77.85% -0.03%
==========================================
Files 353 353
Lines 10794 10832 +38
Branches 471 476 +5
==========================================
+ Hits 8406 8433 +27
- Misses 2222 2230 +8
- Partials 166 169 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced May 21, 2025
When cookies are created with SameSite policy, they won't be available during the authentication flow which uses POST such as OpenID or SAML. This adds support in Strategy to get session ID and restore it later in the login flow. See python-social-auth/social-app-django#481
nijel
added a commit
to nijel/social-app-django
that referenced
this pull request
May 21, 2025
This is a Django implementation for changes introduced in python-social-auth/social-core#1159. Fixes python-social-auth#481
nijel
added a commit
to python-social-auth/social-app-django
that referenced
this pull request
May 26, 2025
This is a Django implementation for changes introduced in python-social-auth/social-core#1159. Fixes #481
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cookies are created with SameSite policy, they won't be available during the authentication flow which uses POST such as OpenID or SAML. This adds support in Strategy to get session ID and restore it later in the login flow.
See python-social-auth/social-app-django#481