You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
...although looking at it more closely, we already default --disable to ASYNC9, and what disable_codes_by_default achieves is adding the codes to --ignore. So in effect we're doubly disabling the codes and you have to both --select and --enable them to get run? Seems bad, we probably shouldn't bother with calling
...nvm nope! Turns out we change the default to --disable depending on if we're standalone or not.
This is a jolly mess, which maaybe made sense before flake8 started enforcing three-letter codes in --ignore (and presumably --select). We probably should stop calling option_manager.extend_default_ignore(default_disabled_error_codes) and make --disable always have the default of ASYNC9, and lean into that end-users should only use enable/disable, and never try to use select/ignore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
oopsies