Use async_generator module for 3.5 support.#17
Merged
smurfix merged 2 commits intopython-trio:masterfrom Mar 26, 2018
Merged
Conversation
smurfix
added a commit
that referenced
this pull request
Mar 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new async generator support as-is means that trio-asyncio no longer imports on 3.5 at all, when before it did. While the docs say it's not officially supported, it worked just fine. In particular, I am using it with PyPy, which seems to support some kind of weird mixture between 3.5 and 3.6, but mostly 3.5 and no async generator syntax.
Every trio user already has the
async_generatormodule installed anyway, since it is a hard dependency of trio itself. I think it is therefore an easy decision to use it to bring back PyPy support.