Skip to content

clarified the 'Networking with Trio' section of the tutorial#1737

Merged
pquentin merged 2 commits intopython-trio:masterfrom
Adrien-Luxey:master
Sep 29, 2020
Merged

clarified the 'Networking with Trio' section of the tutorial#1737
pquentin merged 2 commits intopython-trio:masterfrom
Adrien-Luxey:master

Conversation

@Adrien-Luxey
Copy link
Copy Markdown
Contributor

I misunderstood this section of the tutorial: I thought the "echo client" code provided both server and client.

So I made it clear in the tutorial that the first code sample (the client) does not work without a server listening on the other end.

…o client does not work without a server listening on the designated address
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 29, 2020

Codecov Report

Merging #1737 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1737   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files         114      114           
  Lines       14427    14427           
  Branches     1104     1104           
=======================================
  Hits        14375    14375           
  Misses         37       37           
  Partials       15       15           

Copy link
Copy Markdown
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the result on https://trio--1737.org.readthedocs.build/en/1737/tutorial.html, I only have one suggestion, please tell us what you think.

Comment thread docs/source/tutorial.rst Outdated
Co-authored-by: Quentin Pradet <quentin@pradet.me>
Copy link
Copy Markdown
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pquentin pquentin merged commit 5a84998 into python-trio:master Sep 29, 2020
@trio-bot
Copy link
Copy Markdown

trio-bot Bot commented Sep 29, 2020

Hey @Adrien-Luxey, it looks like that was the first time we merged one of your PRs! Thanks so much! 🎉 🎂

If you want to keep contributing, we'd love to have you. So, I just sent you an invitation to join the python-trio organization on Github! If you accept, then here's what will happen:

  • Github will automatically subscribe you to notifications on all our repositories. (But you can unsubscribe again if you don't want the spam.)

  • You'll be able to help us manage issues (add labels, close them, etc.)

  • You'll be able to review and merge other people's pull requests

  • You'll get a [member] badge next to your name when participating in the Trio repos, and you'll have the option of adding your name to our member's page and putting our icon on your Github profile (details)

If you want to read more, here's the relevant section in our contributing guide.

Alternatively, you're free to decline or ignore the invitation. You'll still be able to contribute as much or as little as you like, and I won't hassle you about joining again. But if you ever change your mind, just let us know and we'll send another invitation. We'd love to have you, but more importantly we want you to do whatever's best for you.

If you have any questions, well... I am just a humble Python script, so I probably can't help. But please do post a comment here, or in our chat, or on our forum, whatever's easiest, and someone will help you out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants