Use .png for favicon on RTD#1761
Merged
pquentin merged 2 commits intopython-trio:masterfrom Oct 14, 2020
Merged
Conversation
Member
Author
|
Just cleaning up here after this was pointed out over at python-trio/pytest-trio#112 (review). |
Member
|
@altendky Thanks! Can you please rebase from master/merge master into your branch? |
Codecov Report
@@ Coverage Diff @@
## master #1761 +/- ##
=======================================
Coverage 99.64% 99.64%
=======================================
Files 114 114
Lines 14446 14446
Branches 1104 1104
=======================================
Hits 14394 14394
Misses 37 37
Partials 15 15 |
Member
Author
|
@pquentin I thought I did for the FreeBSD cache bust and just double checked as well. What do you see missing? |
Member
Author
|
Side note, I personally set repos to require PRs to be up to date to 1) point out when they are not, 2) make sure a real up-to-date build is present before merging, and 3) make the update a button click away. But Trio usually has relevant reasons for being how it is... |
Member
|
Sorry, my bad. Also, I didn't realize you could configure all that stuff in GitHub |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.