Skip to content

Replace codecov with their GHA thing#2653

Merged
A5rocks merged 4 commits intopython-trio:masterfrom
A5rocks:gha-codecov
May 30, 2023
Merged

Replace codecov with their GHA thing#2653
A5rocks merged 4 commits intopython-trio:masterfrom
A5rocks:gha-codecov

Conversation

@A5rocks
Copy link
Contributor

@A5rocks A5rocks commented May 29, 2023

Fixes #2650

I'm not sure this works. We'll see!

@A5rocks
Copy link
Contributor Author

A5rocks commented May 29, 2023

Oh this is gonna wreck builds.sr.ht things. I don't think they work, anyways?

@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #2653 (5aabe95) into master (b21d4b9) will increase coverage by 5.93%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2653      +/-   ##
==========================================
+ Coverage   91.73%   97.67%   +5.93%     
==========================================
  Files         118      124       +6     
  Lines       16444    16731     +287     
  Branches     2970        0    -2970     
==========================================
+ Hits        15085    16342    +1257     
+ Misses       1244      389     -855     
+ Partials      115        0     -115     

see 54 files with indirect coverage changes

@A5rocks
Copy link
Contributor Author

A5rocks commented May 29, 2023

Quick note to self, if this works then:

  • remove JOB_NAME cruft
  • remove the old copying-over-coveragerc hack

@A5rocks A5rocks requested a review from webknjaz May 29, 2023 00:52
@A5rocks
Copy link
Contributor Author

A5rocks commented May 29, 2023

See https://app.codecov.io/gh/python-trio/trio/pull/2653

Looks like it works.

@webknjaz
Copy link
Member

webknjaz commented May 29, 2023

See https://app.codecov.io/gh/python-trio/trio/pull/2653

Looks like it works.

It's 3 uploads short it seems..

Coverage data is based on HEAD ca40b5e
(28 uploads)
compared to BASE b21d4b9
(25 uploads)

Commits have different number of coverage report uploads learn more

@A5rocks
Copy link
Contributor Author

A5rocks commented May 29, 2023

I can certainly see why we had the name, previously. Let me add that back, quickly.

@webknjaz
Copy link
Member

It's 3 uploads short it seems..

I wonder if these are those external FreeBSD jobs.

@A5rocks
Copy link
Contributor Author

A5rocks commented May 29, 2023

Oh wow I panicked too much, looks like this PR (as of last complete snapshot) makes 3 more uploads, not 3 less. Weird, but I'll take it!

@A5rocks A5rocks merged commit 16b6b5e into python-trio:master May 30, 2023
@A5rocks A5rocks deleted the gha-codecov branch May 30, 2023 04:48
@jakkdl jakkdl mentioned this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TODO] Replace codecov uploader with a modern version in GHA

2 participants