Skip to content

Bump Codecov action to v5 #3161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
webknjaz wants to merge 1 commit into from
+6 −5
Closed

Bump Codecov action to v5 #3161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ jobs:
LSP: '${{ matrix.lsp }}'
LSP_EXTRACT_FILE: '${{ matrix.lsp_extract_file }}'
- if: always()
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@v5
with:
directory: empty
name: Windows (${{ matrix.python }}, ${{ matrix.arch }}${{ matrix.extra_name }})
Expand Down Expand Up @@ -284,7 +284,7 @@ jobs:
- if: >-
always()
&& matrix.check_formatting != '1'
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@v5
with:
directory: empty
name: Ubuntu (${{ matrix.python }}${{ matrix.extra_name }})
Expand Down Expand Up @@ -326,7 +326,7 @@ jobs:
- name: Run tests
run: ./ci.sh
- if: always()
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@v5
with:
directory: empty
name: macOS (${{ matrix.python }})
Expand All @@ -345,9 +345,10 @@ jobs:
- name: Install necessary packages
# can't use setup-python because that python doesn't seem to work;
# `python3-dev` (rather than `python:alpine`) for some ctypes reason,
# `curl`, `gpg`, `git`, `jq` for codecov-action v4/v5 to work (https://github.com/codecov/codecov-action/issues/1320).
# `nodejs` for pyright (`node-env` pulls in nodejs but that takes a while and can time out the test).
# `perl` for a platform independent `sed -i` alternative
run: apk update && apk add python3-dev bash nodejs perl
run: apk update && apk add python3-dev bash curl gpg git jq nodejs perl
Copy link

@thomasrockhu-codecov thomasrockhu-codecov Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi, jq should no longer be needed. I'm working on gpg and git, though git is probably still recommended

Copy link
Member Author

@webknjaz webknjaz Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's too bad. The best practice is to build and test from sdist, meaning that there would be no Git repo on disk.

- name: Retrieve the project source from an sdist inside the GHA artifact
# must be after `apk add` because it relies on `bash` existing
uses: re-actors/checkout-python-sdist@release/v2
Expand All @@ -362,7 +363,7 @@ jobs:
id: get-version
run: echo "version=$(python -V | cut -d' ' -f2 | cut -d'.' -f1,2)" >> "${GITHUB_OUTPUT}"
- if: always()
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@v5
with:
directory: empty
name: Alpine
Expand Down
Loading