Increase fudge factor for sleep tests#3411
Merged
A5rocks merged 1 commit intopython-trio:mainfrom Mar 21, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3411 +/- ##
===============================================
Coverage 100.00000% 100.00000%
===============================================
Files 128 128
Lines 19424 19424
Branches 1318 1318
===============================================
Hits 19424 19424
🚀 New features to boost your workflow:
|
jakkdl
approved these changes
Mar 19, 2026
Member
jakkdl
left a comment
There was a problem hiding this comment.
I don't love 2.0 as a factor, but I suppose even if we do sleep twice that still wouldn't hit 2.0 exactly.
I'm almost tempted to have a different fudge factor if it's run in CI vs run on local computer, but not sure it's worth the hassle.
Contributor
Author
|
I agree that it would be nice to have some sort of customization of this (e.g. measure how much variability or maybe rerunning with a longer sleep amount if it's too variable?). I guess that can be a followup for if this test fails again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1664
Just encountered again in https://github.com/python-trio/trio/actions/runs/23277899067/job/67684688370. I've attached the relevant logs below so I can find this PR again if this happens again. For future me, I don't think the fudge factor should be increased more! If we do in fact have an issue with our sleeping, it seems likely to me it's something like "we accidentally slept twice."
Instead, next time, we should just increase
TARGET(or better yet, maybe there's some configuration we can do to make our GitHub provided runners less bad....)