At startup, count how many frames Context.run adds to tracebacks#634
Merged
belm0 merged 2 commits intopython-trio:masterfrom Sep 1, 2018
Merged
At startup, count how many frames Context.run adds to tracebacks#634belm0 merged 2 commits intopython-trio:masterfrom
belm0 merged 2 commits intopython-trio:masterfrom
Conversation
njsmith
changed the title
This is kind of ridiculous overkill, but I was thinking about how you could do it, then wrote some code to experiment, then realized that I had implemented it so we might as well use it... See also: python-trio#631
njsmith
force-pushed
the
count-context-run-frames
branch
from
e6235cf to
b31da5e
Compare
Codecov Report
@@ Coverage Diff @@
## master #634 +/- ##
==========================================
+ Coverage 99.31% 99.31% +<.01%
==========================================
Files 93 93
Lines 10954 10968 +14
Branches 782 783 +1
==========================================
+ Hits 10879 10893 +14
Misses 56 56
Partials 19 19
Continue to review full report at Codecov.
|
belm0
approved these changes
Aug 28, 2018
| def function_with_unique_name_xyzzy(): | ||
| 1 / 0 | ||
|
|
||
| ctx = copy_context() |
belm0
approved these changes
Aug 28, 2018
Member
|
@njsmith please go ahead and merge |
belm0
force-pushed
the
count-context-run-frames
branch
from
2b8e081 to
1cfadda
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is kind of ridiculous overkill, but I was thinking about how you
could do it, then wrote some code to experiment, then realized that
I had implemented it so we might as well use it...