Moved tests from unasync/_tests to tests. #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer need --pyargs because our tests are no longer part of application code.
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
=========================================
Coverage ? 89.06%
=========================================
Files ? 2
Lines ? 64
Branches ? 15
=========================================
Hits ? 57
Misses ? 3
Partials ? 4Continue to review full report at Codecov.
|
It was failing with `ValueError: underlying buffer has been detached`. The fix is to call setup.py as a different process instead: https://cbuelter.wordpress.com/2015/12/15/you-detach-me-i-detach-you/
Member
|
@RatanShreshtha Thanks! I added a few commits to fix the Travis and AppVeyor builds, and updated the location of tests in .gitignore and MANIFEST.in. Please take a look and merge if it looks good to you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.