let iframe contents go fullscreen#13
Merged
BibMartin merged 1 commit intopython-visualization:masterfrom Jun 2, 2016
Merged
Conversation
branca/element.py
Outdated
| '<div style="width:{width};">' | ||
| '<div style="position:relative;width:100%;height:0;padding-bottom:{ratio};">' # noqa | ||
| '<iframe src="{html}" style="position:absolute;width:100%;height:100%;left:0;top:0;">' # noqa | ||
| '<iframe src="{html}" style="position:absolute;width:100%;height:100%;left:0;top:0;" ' #noqa |
Member
There was a problem hiding this comment.
Put a space after the # here to make the linter happy 😉
sanga
force-pushed
the
let_iframe_contents_go_fullscreen
branch
from
f1a7d67 to
4e2c8c2
Compare
Author
|
Should be fixed now |
Member
|
LGTM. @BibMartin can branca is your baby, so I won't merge until you give your 👍 |
Contributor
|
It's fine to me. Merging. Thanks @sanga ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed in order for the fullscreen button in folium to actually do anything from within an iframe (for example in jupyter notebook).