Skip to content

Cleanup Templates strings#4

Merged
ocefpaf merged 7 commits intopython-visualization:masterfrom
BibMartin:cleanup
Mar 3, 2016
Merged

Cleanup Templates strings#4
ocefpaf merged 7 commits intopython-visualization:masterfrom
BibMartin:cleanup

Conversation

@BibMartin
Copy link
Contributor

Do not merge, work in progress...

@BibMartin
Copy link
Contributor Author

Ok @ocefpaf, this is ready for review (I guess I shall stop self-merge on branca).
This PR works in combination with python-visualization/folium#373.
But I need this PR to be merge first, so that I can drop commit BibMartin/folium@acb059c and let folium point to python-visulization/branca.

@BibMartin
Copy link
Contributor Author

@ocefpaf
If you have time to review and merge this PR, I'll make the v0.1.0 release based on this.

btw: can you remind me what needs to be done for release ? As far as I remember it requires:

  • Creating a branch v0.1
  • Putting a tag v0.1.0 at the branch start
  • Putting things into pypi (I don't know how to do that, nor have the rights I think)

@ocefpaf
Copy link
Member

ocefpaf commented Mar 3, 2016

I don't have merge rights here.

Creating a branch v0.1.0

That part is easy 😉

Putting a tag v0.1.0 at the branch start

I usually using GutHub web interface to create the release from that branch. That generates the tag automatically.

Putting things into pypi (I don't know how to do that, nor have the rights I think).

Unless the name branca is taken you have to create a PyPI package. I can do that and add you as administrator of the package.

PS: Reviewing now...


**It is a draft right now!!**
There's no documentation, but you can browse the
[example gallery](http://nbviewer.jupyter.org/github/python-visualization/branca/tree/master/examples/).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is returning a 404 to me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it will work when the PR is merged.

@ocefpaf
Copy link
Member

ocefpaf commented Mar 3, 2016

@BibMartin I need to get more familiar with the code to be helpful here, but everything look good to me. I made a few minor comments.

ocefpaf added a commit that referenced this pull request Mar 3, 2016
Cleanup Templates strings
@ocefpaf ocefpaf merged commit 618c3bd into python-visualization:master Mar 3, 2016
@BibMartin
Copy link
Contributor Author

@BibMartin I need to get more familiar with the code to be helpful here, but everything look good to me. I made a few minor comments.

Too late to adapt code to your comments. I'll make another small PR in the future ; but we can release now.

@BibMartin
Copy link
Contributor Author

Thanks for fast and efficient review !

@ocefpaf
Copy link
Member

ocefpaf commented Mar 3, 2016

Too late to adapt code to your comments.

Oops. I did not consider my review worth of the changes. Anyways, I plan to load the notebooks here, play with them, and then send a PR with proper comments/reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants