Cleanup Templates strings#4
Conversation
|
Ok @ocefpaf, this is ready for review (I guess I shall stop self-merge on branca). |
|
@ocefpaf btw: can you remind me what needs to be done for release ? As far as I remember it requires:
|
|
I don't have merge rights here.
That part is easy 😉
I usually using GutHub web interface to create the release from that branch. That generates the tag automatically.
Unless the name branca is taken you have to create a PyPI package. I can do that and add you as administrator of the package. PS: Reviewing now... |
|
|
||
| **It is a draft right now!!** | ||
| There's no documentation, but you can browse the | ||
| [example gallery](http://nbviewer.jupyter.org/github/python-visualization/branca/tree/master/examples/). |
There was a problem hiding this comment.
Yes, it will work when the PR is merged.
|
@BibMartin I need to get more familiar with the code to be helpful here, but everything look good to me. I made a few minor comments. |
Too late to adapt code to your comments. I'll make another small PR in the future ; but we can release now. |
|
Thanks for fast and efficient review ! |
Oops. I did not consider my review worth of the changes. Anyways, I plan to load the notebooks here, play with them, and then send a PR with proper comments/reviews. |
Do not merge, work in progress...