Since 9abdd8f Marker, Popup and other features are not accessible from folium.features.
I believe what happened is that pep8 marked the imports as unused (as those classes are not used in folium.features), and tests did not catch that because they still involve the legacy usage (e.g. Map.simple_marker instead of Map.add_to(Marker)).
Two things we need to do to avoid this from happening again:
- We should decide where to access features from. I propose the root namespace).
- We should add / modify tests to use also the new feature addition.
Since 9abdd8f Marker, Popup and other features are not accessible from
folium.features.I believe what happened is that pep8 marked the imports as unused (as those classes are not used in
folium.features), and tests did not catch that because they still involve the legacy usage (e.g.Map.simple_markerinstead ofMap.add_to(Marker)).Two things we need to do to avoid this from happening again: