FeatureGroup name argument ignored?

[brwst]

Hello everyone,

I am trying to set a FeatureGroup name for a set of PolyLines, but the name I give to the FeatureGroup isn't sticking in the map layer control menu. Instead, a macro_element_... is returned.

I've set up an example Jupyter Notebook. (in the style of pull request #242) showing this behavior. Should this be expected?

[BibMartin]

Hi @brwst. You're true there's a bug here.

This is due to __init__ method of FeatureGroup that starts with

    def __init__(self, name=None, overlay=True, control=True):
        super(FeatureGroup, self).__init__(overlay=overlay, control=control)
        ...

while it should be

    def __init__(self, name=None, overlay=True, control=True):
        super(FeatureGroup, self).__init__(overlay=overlay, control=control, name=name)
        ...

A short term workaround is to add in your code:

feature_group.layer_name = 'My feature group'

[brwst]

Thanks for your help @BibMartin -- the workaround works fine on my end.

[pjandrews]

I just installed folium today (8/5) and am seeing this issue.

Here is the version I'm using:

import folium
folium.version
'0.2.1'

[brwst]

Hello @pjandrews

I'm not able to replicate your problem -- folium 0.2.1 seems to fix this issue for me. Do you still see the FeatureGroup naming issue when using this example notebook?

[ocefpaf]

I cannot reproduce it either 😕

[pjandrews]

@brwst,
The strange thing is that I have two computers, both with 0.2.1 and when I run the same code the error is happening on one, but not the other. When I run the example notebook you provided on the computer with the issue I don't see the issue. Here is some of my code if you're interested.

def LDM(df,adb):
global map_

#create a DataFrame
df_ldm = df_ld[(df_ld['Lat'] > -200)&(df_ld['Lat'] < 200)&(df_ld['Lat'] != -1)]

#create and name the layer
fgLD=folium.FeatureGroup(name=adb+'_Large Download')

#this is the workaround
#fgLD.layer_name = adb+'_Large Download'

#add a new point to the map based on info from the DF
for lat,lon,status,lc,st,rat,tp in zip(df_ldm['Lat'],df_ldm['Lon'],df_ldm['STATUS'],df_ldm['date'],
df_ldm['START_TIME'],df_ldm['RAT Start'],
df_ldm['Throughput']):

    folium.CircleMarker([lat,lon], radius=150, color=color(status), fill_color=fill_color(rat),popup=popup(lc,st,rat,tp)).add_to(fgLD)    

map_.add_child(fgLD)

#call the function, add layer control, create the map
LDM(dfadb,adb)
map_.add_child(folium.LayerControl())
map_.save(wloc+''+loc+''+build+''+op+'.html')](url)