Skip to content

Have GeoJson raise a more descriptive error when passed a GeoDataFrame with missing geometries #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Conengmo merged 4 commits into from
Jan 12, 2019
Merged

Have GeoJson raise a more descriptive error when passed a GeoDataFrame with missing geometries #1039

Conengmo merged 4 commits into from
Jan 12, 2019

Conversation

@wtadler
Copy link
Contributor

@wtadler wtadler commented Dec 11, 2018

Closes #1037.

@wtadler
More descriptive error in GeoJson
8bde5ce 
Have GeoJson raise a more descriptive error when passed a GeoDataFrame with missing geometries. Closes python-visualization#1037.
ocefpaf
ocefpaf reviewed Dec 11, 2018
View reviewed changes
ocefpaf
ocefpaf reviewed Dec 12, 2018
View reviewed changes
ocefpaf
ocefpaf reviewed Dec 13, 2018
View reviewed changes
@Conengmo Conengmo added the in discussion This PR or issue is being discussed label Dec 23, 2018
@Conengmo Conengmo added ready PR is ready for merging and removed in discussion This PR or issue is being discussed labels Jan 12, 2019
@Conengmo Conengmo merged commit 49d724d into python-visualization:master Jan 12, 2019
@Conengmo
Copy link
Member

Conengmo commented Jan 12, 2019

Thanks for helping with this @wtadler!

@Conengmo Conengmo removed the ready PR is ready for merging label Jan 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocefpaf ocefpaf ocefpaf left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wtadler @Conengmo @ocefpaf