Skip to content

Add auto_start parameter to locate control plugin#1220

Merged
Conengmo merged 4 commits intopython-visualization:masterfrom
fullonic:start_locate_control
Jan 5, 2020
Merged

Add auto_start parameter to locate control plugin#1220
Conengmo merged 4 commits intopython-visualization:masterfrom
fullonic:start_locate_control

Conversation

@fullonic
Copy link
Copy Markdown
Contributor

@fullonic fullonic commented Nov 3, 2019

Include the new functionality refereed in #1219

@fullonic fullonic force-pushed the start_locate_control branch 2 times, most recently from cf4e7e1 to 6d44b7a Compare November 3, 2019 17:39
Copy link
Copy Markdown
Contributor Author

@fullonic fullonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolve conflicts

@fullonic
Copy link
Copy Markdown
Contributor Author

fullonic commented Nov 3, 2019

The problem with Travis is related with testing the Search plugin. All json files from rawcdn.githack are returning 502.
For example:
https://rawcdn.githack.com/PublicaMundi/MappingAPI/master/data/geojson/us-states.json

Already working! :)

@fullonic fullonic force-pushed the start_locate_control branch from 2262d71 to 877bcbc Compare November 12, 2019 15:14
Copy link
Copy Markdown
Member

@Conengmo Conengmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done @fullonic, it works and the docstring and example notebook are also updated. I'll go ahead and merge this.

@Conengmo Conengmo merged commit 61daf0c into python-visualization:master Jan 5, 2020
@fullonic
Copy link
Copy Markdown
Contributor Author

Great! thanks for your work @Conengmo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants