Skip to content

Selenium notebook tests#1311

Merged
Conengmo merged 49 commits intopython-visualization:masterfrom
Conengmo:selenium-tests
May 10, 2020
Merged

Selenium notebook tests#1311
Conengmo merged 49 commits intopython-visualization:masterfrom
Conengmo:selenium-tests

Conversation

@Conengmo
Copy link
Copy Markdown
Member

@Conengmo Conengmo commented Apr 26, 2020

Do selenium tests on our example notebooks. The steps are:

  • execute the notebook so it's using our up to date code
  • convert the notebook to html
  • extract iframes from the html
  • store each iframe in an html file
  • load each html file with selenium
  • check if the map loaded
  • verify there are no errors in the JS console

After merging this we can see what other tests can be discarded.

In the contributing guide I removed the part about Firefox. We still use it in the code but those tests are marked to allow failure. I want to revisit that code after this.

Reuse the WebDriver instance so the cache is preserved. This means doing less requests for static content.

@Conengmo Conengmo added the work in progress Work is in progress on a PR, check the PR to see its status label Apr 26, 2020
Comment thread tests/test_selenium.py Outdated
Comment thread tests/test_selenium.py Outdated
@amit1rrr
Copy link
Copy Markdown

@Conengmo @stickler-ci Sorry to intrude but I noticed this PR contains Jupyter notebook files that are hard to review on GitHub due to the JSON diffs.

You might want to checkout ReviewNB, code review tool for notebooks. Provides visual diffs & commenting for Jupyter notebooks on GitHub. Completely free for open source repositories.

Disclaimer: I built ReviewNB

diff_and_commenting

@Conengmo Conengmo force-pushed the selenium-tests branch 2 times, most recently from 1e08bd2 to ce95af5 Compare May 7, 2020 06:14
@Conengmo Conengmo marked this pull request as ready for review May 7, 2020 06:14
Comment thread tests/selenium/test_selenium.py Outdated
@Conengmo Conengmo removed the work in progress Work is in progress on a PR, check the PR to see its status label May 9, 2020
@Conengmo Conengmo changed the title Selenium tests Selenium notebook tests May 9, 2020
@Conengmo Conengmo merged commit 6e7104f into python-visualization:master May 10, 2020
@Conengmo Conengmo deleted the selenium-tests branch May 10, 2020 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants