Selenium notebook tests#1311
Merged
Conengmo merged 49 commits intopython-visualization:masterfrom May 10, 2020
Merged
Conversation
stickler-ci
reviewed
Apr 28, 2020
|
@Conengmo @stickler-ci Sorry to intrude but I noticed this PR contains Jupyter notebook files that are hard to review on GitHub due to the JSON diffs. You might want to checkout ReviewNB, code review tool for notebooks. Provides visual diffs & commenting for Jupyter notebooks on GitHub. Completely free for open source repositories. Disclaimer: I built ReviewNB |
1e08bd2 to
ce95af5
Compare
stickler-ci
reviewed
May 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Do selenium tests on our example notebooks. The steps are:
After merging this we can see what other tests can be discarded.
In the contributing guide I removed the part about Firefox. We still use it in the code but those tests are marked to allow failure. I want to revisit that code after this.
Reuse the WebDriver instance so the cache is preserved. This means doing less requests for static content.