Don't allow latest-branca test failure#1326
Merged
ocefpaf merged 1 commit intopython-visualization:masterfrom May 10, 2020
Merged
Don't allow latest-branca test failure#1326ocefpaf merged 1 commit intopython-visualization:masterfrom
ocefpaf merged 1 commit intopython-visualization:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We test folium against the master branch of branca. When we made some big changes in branca we set this test to allow failure, because it would fail all the time. Now that it's stable don't allow failure again. The lastest folium should work with the lastest branca and if it does not we want to be warned early.