Fix broken links in two example notebooks#1557
Merged
ocefpaf merged 2 commits intopython-visualization:mainfrom Dec 29, 2021
Merged
Fix broken links in two example notebooks#1557ocefpaf merged 2 commits intopython-visualization:mainfrom
ocefpaf merged 2 commits intopython-visualization:mainfrom
Conversation
ocefpaf
reviewed
Dec 29, 2021
| "\n", | ||
| "url = (\n", | ||
| " \"https://github.com/ocefpaf/secoora_assets_map/blob/a250729bbcf2ddd12f46912d36c33f7539131bec/secoora_icons/rose.png\"\n", | ||
| " \"https://raw.githubusercontent.com/ocefpaf/secoora_assets_map/\"\n", |
Member
There was a problem hiding this comment.
Thanks for the permalink. Note that we need the raw URL here to display the image.
ocefpaf
reviewed
Dec 29, 2021
| "source": [ | ||
| "us_cities = geopandas.sjoin(cities, states, how=\"inner\", op=\"within\")\n", | ||
| "us_cities = geopandas.sjoin(cities, states, how=\"inner\", predicate=\"within\")\n", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two example notebooks had broken (dead) links.
This is a quick and dirty fix that replaces the broken links with equivalent links from elsewhere (i.e. same data at different location).
However, I wonder whether it would be better to include the linked data in our own repository instead?