Skip to content

Pre commit#1632

Merged
ocefpaf merged 3 commits intopython-visualization:mainfrom
ocefpaf:pre-commit
Nov 9, 2022
Merged

Pre commit#1632
ocefpaf merged 3 commits intopython-visualization:mainfrom
ocefpaf:pre-commit

Conversation

@ocefpaf
Copy link
Copy Markdown
Member

@ocefpaf ocefpaf commented Oct 10, 2022

Continuation of #1567

@ocefpaf ocefpaf requested a review from Conengmo October 10, 2022 15:37
@ocefpaf
Copy link
Copy Markdown
Member Author

ocefpaf commented Oct 10, 2022

@Conengmo, b/c this PR touches several files I'll leave to you to merge it or not.

@Conengmo
Copy link
Copy Markdown
Member

Conengmo commented Nov 3, 2022

Good initiative!

I understand using pre-commit locally. But what is the Github Action supposed to do, will it fail if pre-commit changes something?

By the way, did you see this warning? https://github.com/python-visualization/folium/actions/runs/3220435260

@ocefpaf
Copy link
Copy Markdown
Member Author

ocefpaf commented Nov 8, 2022

I understand using pre-commit locally. But what is the Github Action supposed to do, will it fail if pre-commit changes something?

If it fails a user can fix it by reading the error message. We could configure pre-commit-ci to commit the fix but I find that very intrusive and leads to conflicts that may confuse new contributors.

Copy link
Copy Markdown
Member

@Conengmo Conengmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for explaining. Let's merge this now and once we've got the open PRs out of the way add the same pre-commit stuff as branca has.

@Conengmo Conengmo added the ready PR is ready for merging label Nov 9, 2022
@ocefpaf ocefpaf merged commit bee611b into python-visualization:main Nov 9, 2022
@ocefpaf ocefpaf deleted the pre-commit branch November 9, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready PR is ready for merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants