Skip to content

Use uv for streamlit_folium installation #2172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 12, 2025
Merged

Use uv for streamlit_folium installation #2172

merged 3 commits into from
Aug 12, 2025

Conversation

@hansthen
Copy link
Collaborator

@hansthen hansthen commented Aug 9, 2025 •
edited
Loading

This is a bit of trial and error, since I am not very familiar with uv.

@hansthen hansthen requested a review from ocefpaf August 10, 2025 12:38
ocefpaf
ocefpaf approved these changes Aug 11, 2025
View reviewed changes
Copy link
Member

@ocefpaf ocefpaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. What was the motivation? I'm not against uv, but whatever we do here should work with plain pip too. If we had issues with pip we should try to solve them. If it is just speed, merge away!

@hansthen
Copy link
Collaborator Author

hansthen commented Aug 11, 2025

LGTM. What was the motivation? I'm not against uv, but whatever we do here should work with plain pip too. If we had issues with pip we should try to solve them. If it is just speed, merge away!

As part of our test suite, Frank and I added integration tests with some popular downstream packages (geopandas and streamlit-folium.) In the github workflow we used to install streamlit-folium using pip and then install the current folium into that environment and then running the tests from streamlit-folium. That stopped working because the streamlit-folium package switched to uv.

@hansthen hansthen merged commit 73f0abd into python-visualization:main Aug 12, 2025
15 checks passed
hansthen added a commit to hansthen/folium that referenced this pull request Nov 2, 2025
@hansthen
Use uv for streamlit_folium installation (python-visualization#2172)
10503dd 
* Use uv for streamlit_folium installation

* Change working directory

* Run folium installation from streamlit_folium
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocefpaf ocefpaf ocefpaf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hansthen @ocefpaf