Skip to content

Add documentation for coordinate ordering (issue #1082)#2225

Merged
hansthen merged 5 commits into
python-visualization:mainfrom
Seascavenger:main
Jun 7, 2026
Merged

Add documentation for coordinate ordering (issue #1082)#2225
hansthen merged 5 commits into
python-visualization:mainfrom
Seascavenger:main

Conversation

@Seascavenger
Copy link
Copy Markdown
Contributor

Closes #1082

This PR adds documentation explaining the coordinate ordering difference between Leaflet and GeoJSON.

@hansthen
Copy link
Copy Markdown
Collaborator

Closes #1082

This PR adds documentation explaining the coordinate ordering difference between Leaflet and GeoJSON.

Thanks a lot! The documentation is very clear. I noticed a few formatting issues (which also fail the automated tests). Did you check out https://github.com/python-visualization/folium/blob/b22df0b7ad48fc124d836d708df79c1b9e6e2623/.github/CONTRIBUTING.md?

But I'd be very happy to accept this if you can change these minor issues.

@Seascavenger
Copy link
Copy Markdown
Contributor Author

Thanks for the feedback! I will fix the formatting issues right away.

@hansthen
Copy link
Copy Markdown
Collaborator

Thanks for the feedback! I will fix the formatting issues right away.

Thank you for picking this up. Any help is greatly appreciated.

@Seascavenger
Copy link
Copy Markdown
Contributor Author

pre-commit.ci autofix

@Seascavenger
Copy link
Copy Markdown
Contributor Author

Fixed the docstring syntax error in GeoJson class. Ready for review.

@hansthen
Copy link
Copy Markdown
Collaborator

hansthen commented Jun 6, 2026

I will have a look over the weekend. Currently the automated tests are running.

@hansthen
Copy link
Copy Markdown
Collaborator

hansthen commented Jun 7, 2026

There seems to be an issue with the formatting that is not caused by your change. (It was fixed in a recent PR). You may need to rebase this PR on the latest master. I will merge to see if a merge fixes the issue.

@hansthen hansthen merged commit 6b75c07 into python-visualization:main Jun 7, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lat/long ordering in geojson

2 participants