More docstrings and options in Icon#243
Merged
themiurgo merged 1 commit intopython-visualization:masterfrom Nov 12, 2015
Merged
More docstrings and options in Icon#243themiurgo merged 1 commit intopython-visualization:masterfrom
themiurgo merged 1 commit intopython-visualization:masterfrom
Conversation
Contributor
|
Looks good to me! 👍 |
Member
There was a problem hiding this comment.
How about we change or an html #...... to , or an html color code?
Contributor
Author
|
@ocefpaf Ok for your 2 remarks. |
Member
There was a problem hiding this comment.
Let's open an issue for that and do this for the rest of the plugins. You can assing me for that 😉
Member
|
I am done. Awesome work @BibMartin. @themiurgo care to do the honors and merge this one after the rebase? |
BibMartin
force-pushed
the
icon_prefix
branch
from
fc6ca4d to
d5ce0b9
Compare
Contributor
Author
|
Rebase done. Thanks @themiurgo and @ocefpaf for fast review. |
themiurgo
added a commit
that referenced
this pull request
Nov 12, 2015
More docstrings and options in Icon
Contributor
|
Merged! 👍 |
ocefpaf
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yet another small one.
I realized that font-awesome icons where only available when you set
prefix:'fa'An occasion to do the docstring that a lazy guy has left in
TODO