Popup tests

[ocefpaf]

Complements #253 and closes #252.

NB the test_popup_unicode is a known failure.

[ocefpaf]

This PR is not ready. We need:

• Fix unicode chars test
• Check for different popup width

[ocefpaf]

@BibMartin do you have a better suggestion than this?

[BibMartin]

I would have done

_id = list(popup.html._children.keys())[0]

but it's really equivalent.

[ocefpaf]

but it's really equivalent.

The result? Yes. But your way is more readable. Changing that...

[themiurgo]

@ocefpaf This list might help in building strong tests.
https://github.com/minimaxir/big-list-of-naughty-strings

[ocefpaf]

@ocefpaf This list might help in building strong tests.
https://github.com/minimaxir/big-list-of-naughty-strings

Thanks! I will take a look. (I like the name 😉)

[ocefpaf]

@BibMartin can you review and merge. I will add more tests later on.

[BibMartin]

@ocefpaf
Just for curiosity: what is it for ?

[ocefpaf]

So we can use "Ça c'est chouette" instead of u"Ça c'est chouette". Embrace the future 😉

[BibMartin]

It's ok. Merging 🎉

[ocefpaf]

Thanks!