Popup can accept strings explicitly

[jelmelk]

This is to address #259. Assuming I did the PR properly.

[ocefpaf]

Awesome @jelmelk! Thanks for the PR!

Can you build a test for this behavior?

[jelmelk]

Am I correct to assume you're talking about test_folium.py?

[ocefpaf]

You are adding this behavior for Marker, CircleMarker, and RegularPolygonMarker. Correct?

I guess we should also add this for lines...

[ocefpaf]

Am I correct to assume you're talking about test_folium.py?

Yep.

[jelmelk]

You are adding this behavior for Marker, CircleMarker, and RegularPolygonMarker. Correct?

Yes, those are the only ones that needed it. So would it be a single function for each one?

[ocefpaf]

Yes, those are the only ones that needed it. So would it be a single function for each one?

Maybe we could have been more clever and try to avoid that repetition, but your implementation is OK. I will take a better look tomorrow (going to bed now).

@BibMartin any observations?

[jelmelk]

I agree, but like I said in #259 (comment) it could be done individually or in one spot that catches all three. Let me know tomorrow, I can change it if needed.

[BibMartin]

Hi @jelmelk ; thanks for the PR !
Provided the Marker class is very simple, I think you can implement it only in Marker and let the other classes inherit from it.
BTW it would make sens to have all marker stuff inherit from the same root class.
Anyway, we're only sparing 6 lines of code this way ➡️ it's not strategic and I would accept the PR like this.

[jelmelk]

Due to the branch mix up on my part, I'm closing this PR.