-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Docs updates (incomplete) #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not copy the docstring here. We can (and should) build a detailed API docs based on the docstrings automatically.
This part should be simple examples only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did have it more detailed, but I wasn't sure what was the preferred method (consistency reasons). I have ideas for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My imagine the index.rst as quick intro.
Later on we can add more, like a typical automodule in the fashion:
$ cat folium.rst
:mod:`folium`
--------------
.. automodule:: foium.folium
:members:
:undoc-members:
:show-inheritance:Same for map.py, features.py, etc. But before that we need to review the docstrings too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it for this reason that the autoclass commands do not provide currently any documentation in http://folium.readthedocs.org/en/latest/module/features.html#polyline?
|
@jelmelk This is looking good. Thanks for doing this! I made a few comments, but there is still a long way to go. (Not your fault. We neglected the docs for way too long!) I would like to invite more people to read this too @python-visualization/folium 😉 |
|
@jelmelk are you still interested in finishing this PR? If not let me know so I can try to pick your changes and issue a new one. |
|
Closing this b/c it seems that @jelmelk is no longer available to finish it. |
Just a starting point. Leave feedback/comments/complaints