Skip to content

Conversation

@jelmelk
Copy link
Contributor

@jelmelk jelmelk commented Dec 1, 2015

Just a starting point. Leave feedback/comments/complaints

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not copy the docstring here. We can (and should) build a detailed API docs based on the docstrings automatically.

This part should be simple examples only.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did have it more detailed, but I wasn't sure what was the preferred method (consistency reasons). I have ideas for that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My imagine the index.rst as quick intro.

Later on we can add more, like a typical automodule in the fashion:

$ cat folium.rst

:mod:`folium`
--------------

.. automodule:: foium.folium
    :members:
    :undoc-members:
    :show-inheritance:

Same for map.py, features.py, etc. But before that we need to review the docstrings too.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it for this reason that the autoclass commands do not provide currently any documentation in http://folium.readthedocs.org/en/latest/module/features.html#polyline?

@ocefpaf
Copy link
Member

ocefpaf commented Dec 1, 2015

@jelmelk This is looking good. Thanks for doing this! I made a few comments, but there is still a long way to go. (Not your fault. We neglected the docs for way too long!)

I would like to invite more people to read this too @python-visualization/folium 😉

@BibMartin BibMartin mentioned this pull request Dec 2, 2015
@ocefpaf ocefpaf added the documentation Documentation about a certain topic should be added label Dec 4, 2015
@ocefpaf ocefpaf added this to the v0.2.1 milestone Dec 4, 2015
@ocefpaf ocefpaf modified the milestones: v0.2.1, v0.3.0 Dec 17, 2015
@ocefpaf
Copy link
Member

ocefpaf commented Sep 22, 2016

@jelmelk are you still interested in finishing this PR? If not let me know so I can try to pick your changes and issue a new one.

@ocefpaf ocefpaf modified the milestones: v0.3.0, v0.4.0 Mar 6, 2017
@ocefpaf
Copy link
Member

ocefpaf commented Jun 24, 2017

Closing this b/c it seems that @jelmelk is no longer available to finish it.
We can re-open if someone else is interested into this.

@ocefpaf ocefpaf closed this Jun 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Documentation about a certain topic should be added

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants