Skip to content

deprecation added#271

Merged
ocefpaf merged 1 commit intopython-visualization:masterfrom
jelmelk:dep
Dec 2, 2015
Merged

deprecation added#271
ocefpaf merged 1 commit intopython-visualization:masterfrom
jelmelk:dep

Conversation

@jelmelk
Copy link
Copy Markdown
Contributor

@jelmelk jelmelk commented Dec 2, 2015

To address this #269

ocefpaf added a commit that referenced this pull request Dec 2, 2015
@ocefpaf ocefpaf merged commit 06df1a2 into python-visualization:master Dec 2, 2015
@ocefpaf
Copy link
Copy Markdown
Member

ocefpaf commented Dec 2, 2015

Thanks @jelmelk!

@ocefpaf
Copy link
Copy Markdown
Member

ocefpaf commented Dec 2, 2015

@BibMartin unrelated to this PR I just noticed that the _repr_html_ is broken when we use line or multiline. I will update all the notebooks here with latest master and report an issue later.

@jelmelk jelmelk deleted the dep branch December 2, 2015 14:21
@BibMartin
Copy link
Copy Markdown
Contributor

Great fast job. Congrats @jelmelk

@ocefpaf

I will update all the notebooks here with latest master and report an issue later.

👍 btw, I'm thinking we may incorporate a few example notebooks into the tests, to make sure they still run. Why not using something like this ?

@ocefpaf
Copy link
Copy Markdown
Member

ocefpaf commented Dec 2, 2015

I used runipy in the past to test notebook output, but the problem, in this case, are that the changes will be hard to make sense (like diffs of base64 encoded PNGs).

I think we can do an OK job by strengthen our tests as their are and increase html comparisons. I am sure that the _repr_html_ in that case has a flaw that we can test.

Or maybe (crazy idea alert) we can add runipy, generate HTMLs, publish them, and inspect them before merging a PR.

@BibMartin
Copy link
Copy Markdown
Contributor

Let's continue this discussion in a dedicated issue #272

@ocefpaf ocefpaf mentioned this pull request Dec 2, 2015
@ocefpaf ocefpaf added bug An issue describing unexpected or malicious behaviour documentation Documentation about a certain topic should be added labels Feb 12, 2016
@ocefpaf ocefpaf added this to the v0.2.0 milestone Feb 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug An issue describing unexpected or malicious behaviour documentation Documentation about a certain topic should be added

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants