Add possibility to have unembedded GeoJSON.#290
Add possibility to have unembedded GeoJSON.#290ocefpaf merged 2 commits intopython-visualization:masterfrom
Conversation
How difficult would it be to read the style from the file and still not embed? We do not need to do this in this PR, but I want to keep that idea around. |
There was a problem hiding this comment.
I am not opposed to this pattern: read in dir(x), but I think hasattr(object, name) is more common? Any special reason for doing that?
I guess this has few importance ; I'm just a goldfish who forgot the clean syntax. Corrected.
This one is more important ; for instance, someone may be willing to provide an I've corrected both lines. |
I just asked for shear curiosity. Sometimes I learn new things by asking 😉
I suspected so, but haven't tested it. Good to know! Thanks! Merging this... |
Add possibility to have unembedded GeoJSON.
Addresses #285.
Instead of having an
embedoption as @ocefpaf suggested, the user shall passdata=open(filename)if he wants to have the file embedded, anddata=filenameotherwise.Note that the
style_functioncannot be applyed in the latter case, because the file won't be openned.