Skip to content

Conversation

@ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Mar 14, 2016

@BibMartin can you review this to make sure the 3 bug fix commits are there?

@BibMartin
Copy link
Contributor

@ocefpaf I can see the 3 commits, but i'm surprised that you v0.2.1 branch is forked from commit 824e7af ; I would have expected a fork from tag v0.2.0 (a911d2f).

BTW: don't you want to create a branch v0.2 that would hosts hotfix tags like v0.2.0, v0.2.1 etc. Maybe this shall be done from v0.3.

screenshot from 2016-03-14 16-59-28

@ocefpaf
Copy link
Member Author

ocefpaf commented Mar 14, 2016

@ocefpaf I can see the 3 commits, but i'm surprised that you v0.2.1 branch is forked from commit 824e7af ; I would have expected a fork from tag v0.2.0 (a911d2f).

Indeed. I checked out the v0.2.0 branch and that should have the a911d2f. I will try again, not sure what went wrong.

BTW: don't you want to create a branch v0.2 that would hosts hotfix tags like v0.2.0, v0.2.1 etc. Maybe this shall be done from v0.3.

Not sure. I am OK creating a branch/tag for each release. If you think there are advantages to that approach we can try.

@ocefpaf ocefpaf closed this Mar 14, 2016
@ocefpaf ocefpaf deleted the v0.2.1 branch March 14, 2016 16:36
@ocefpaf ocefpaf mentioned this pull request Mar 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants