Add a float image plugin#537
Merged
ocefpaf merged 2 commits intopython-visualization:masterfrom Oct 22, 2016
Merged
Conversation
Member
|
Nice one!
That is fine for now. At least people will be able to add extra image elements easier now. Can you add a test for the new feature? |
ocefpaf
reviewed
Oct 21, 2016
| # Verify that the div has been created. | ||
| tmpl = Template(""" | ||
| <img id="{{this.get_name()}}" alt="float_image" | ||
| src="https://raw.githubusercontent.com/SECOORA/static_assets/master/maps/img/rose.png" |
Member
There was a problem hiding this comment.
We should probably copy that image here.
Member
|
Awesome! Another one bites the dust! |
This was referenced Oct 22, 2016
sanga
pushed a commit
to sanga/folium
that referenced
this pull request
Oct 24, 2017
Add a float image plugin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #319 with a logic similar to
ScrollZoomTogglerinstead of usingL.DomUtil. It is simpler, but the relative position is not against the actual map and may be misleading.